Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resoves #977. Document how to compile a local asciidoctor ruby code base #978

Merged

Conversation

djencks
Copy link
Contributor

@djencks djencks commented May 21, 2020

No description provided.

** Using a symlink: `ln -s $ASCIIDOCTOR_RB packages/core/build/asciidoctor`
** Copying: `cp -r $ASCIIDOCTOR_RB packages/core/build/`
** Unpacking a gem:
----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might use a list continuation to indent the listing block:

Suggested change
----
+
----

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked that so much I changed most of the other usages!

----
* For all of these, `touch packages/core/build/asciidoctor.tar.gz` will prevent `npm build --prefix packages/core` from overwriting your copy with a downloaded one.
* To actually use your local source you'll need to force recompile by:
----
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might use a list continuation to indent the listing block:

ditto

Suggested change
----
+
----

Copy link
Member

@ggrossetie ggrossetie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good additions to the contributing guide! Thanks 👍

@djencks djencks force-pushed the issue-977-doc-local-asciidoctor branch from 7d3d9a0 to 19a8a85 Compare May 21, 2020 22:43
@ggrossetie
Copy link
Member

Excellent thanks again! 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants