Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAttributes() returns Opal.nil as value (instead of undefined) #920

Closed
ggrossetie opened this issue Apr 12, 2020 · 0 comments · Fixed by #921
Closed

getAttributes() returns Opal.nil as value (instead of undefined) #920

ggrossetie opened this issue Apr 12, 2020 · 0 comments · Fixed by #921
Assignees
@ggrossetie
Labels
🐛 bug
Milestone
v2.2.x

Comments

@ggrossetie
Copy link
Member

The API must not leak Opal.nil value.
So the getAttributes function must replace Opal.nil values with undefined.

Please note that this is also problematic because the behavior is not consistent with getAttribute:

getAttribute('foo') // undefined
getAttributes().foo // Opal.nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggrossetie ggrossetie

Labels
🐛 bug
Projects
None yet
Milestone
v2.2.x
Development

Successfully merging a pull request may close this issue.

resolves #920 replace Opal.nil with undefined in AbstractNode.getAttributes
1 participant
@ggrossetie