Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When registering a Converter from plain JS, we must bridge the "handles?" method #906

Closed
ggrossetie opened this issue Apr 8, 2020 · 0 comments · Fixed by #917
Closed

Comments

@ggrossetie
Copy link
Member

The base converter has a default method handles? that always return true:

https://github.com/asciidoctor/asciidoctor/blob/c55fc9fea20d57f14e9552073dab5a27a4728f71/lib/asciidoctor/converter.rb#L82-L84

When registering a Converter from plain JS we should bridge this method.
We should also assign handles? function if the converter has a handles? or handles function define.

In other words, handles? should always be defined either with the default implementation that always return true or with the actual implementation provided by the converter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant