Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an explicit failure if the regular expression does not match #890

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Add an explicit failure if the regular expression does not match #890

merged 1 commit into from
Mar 26, 2020

Conversation

ggrossetie
Copy link
Member

@ggrossetie ggrossetie commented Mar 25, 2020 •
edited
Loading

resolves #885

The logger date time can contain 3 or 6 digits for milliseconds, update the regular expression accordingly.

@ggrossetie
Add an explicit failure if the regular expression does not match
54e0f1a 
Milliseconds can contain 3 or more digits.
Use one or more digits in the regular expression to be safe.
@ggrossetie ggrossetie merged commit d6beae0 into asciidoctor:master Mar 26, 2020
@ggrossetie ggrossetie deleted the explicit-fail-pattern branch March 26, 2020 12:57
@snyk-bot snyk-bot mentioned this pull request May 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A Logger test is "randomly" failing on the CI
1 participant
@ggrossetie