-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolves #844 map Document.playbackAttributes #853
resolves #844 map Document.playbackAttributes #853
Conversation
I'll admit I'm a bit uneasy about mapping these APIs. The APIs and the behavior were never meant to be public. (That's why they seem so awkward). Perhaps we can add a disclaimer to them that it's an advanced feature, then focus our attention the proper solution upstream, which is to proxy the document attributes so they reflect the correct state when viewed from the tree. |
I'm uneasy too. Rather than (only) marking them 'advanced' I think it would be better to indicate that a better solution is hoped for in the future and these methods may disappear. |
I agree but right now they can be useful in some scenarios
Sure, as soon as Asciidoctor core provides a better alternative, I will remove these methods and map the new ones. Do you have suggestions about what we should add in the JavaScript documentation? /**
* Replay attribute assignments at the block level.
* /!\ This low-level API will probably be removed in the next major version /!\
*/ |
I definitely recognize the need.
We really have no idea at this point. They are public only because they haven't been updated to be private. Remember that prior to Asciidoctor 2, there was no delineation. So it's more that a decision just hasn't been made yet.
I think it should be a very direct message.
|
@mojavelinux Sounds good, thanks for your input! I will update the documentation to use a clear and direct message as suggested. |
resolves #844