This repository has been archived by the owner on Apr 29, 2020. It is now read-only.
Resolves #2, Use a simpler implementation to read templates #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace File.exists and File.directory? with File.read because they are not available in a browser environment.
Also narrow down the number of locations where we were looking for templates:
- #{template_dir}/#{name}.jade
- #{template_dir}/jade/#{name}.jade
ggrossetie
commented
Oct 1, 2016
| ::File.read(name) | ||
| rescue IOError | ||
| # Ignore error as Asciidoctor expect a nil value if the template is not found | ||
| nil |
There was a problem hiding this comment.
@mojavelinux Could you please confirm that's this is the correct way to do it ?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace File.exists and File.directory? with File.read because they are not available in a browser environment.
Also narrow down the number of locations where we were looking for templates:
#{template_dir}/#{name}.jade#{template_dir}/jade/#{name}.jade