Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed comment of getSourceLocation()'s returns #1699

Merged
merged 4 commits into from
May 13, 2023
Merged

Fixed comment of getSourceLocation()'s returns #1699

merged 4 commits into from
May 13, 2023

Conversation

jiakuan
Copy link
Contributor

@jiakuan jiakuan commented May 13, 2023

No description provided.

@ggrossetie
Copy link
Member

Thanks!
Could you please also fix the same mistake on the type definition?

asciidoctor.js/packages/core/types/index.d.ts

Line 2082 in a8c4c96

* @returns the style for this block

@jiakuan
Copy link
Contributor Author

jiakuan commented May 13, 2023

Done

@ggrossetie
Copy link
Member

Awesome, thanks ❤️

@ggrossetie ggrossetie merged commit d9a403e into asciidoctor:main May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggrossetie ggrossetie ggrossetie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiakuan @ggrossetie