Fix conditional export #1695
Merged
Fix conditional export #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggrossetie
reviewed
Apr 19, 2023
| @@ -9,7 +9,7 @@ | |||
| "exports": { | |||
| "node": { | |||
| "import": "./dist/node/asciidoctor.js", | |||
| "require": "./src/node/asciidoctor.cjs" | |||
|
@benjaminleonard could you please revert this commit |
This reverts commit f492a14.
|
Whoops, got ahead of myself. Done |
|
When you do have a sec to bump the RC it would be much appreciated, it's the last piece of the puzzle to get our react asciidoc renderer running in production. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guessing this worked with
npm linkbecause thesrcdir exists. I can confirm the change works importing thecjswithremix.