Include cjs in release
#1686
Merged
Include cjs in release
#1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm in favor as Antora will need this as well. I have no plans to switch Antora to ESM right now as it requires a major change to the build process. Having a CJS export would be very helpful. |
ggrossetie
reviewed
Jan 30, 2023
|
Thanks! |
|
If you get the chance I would love an alpha release including this PR. Thanks! |
|
At this point, I think I should release a "rc". I will probably upgrade to the latest release of Opal as well (from 1.5.1 to 1.7.3). |
|
That'd be perfect! Thanks |
|
@benjaminleonard I just released 3.0.0-rc.1 but I noticed that Vite ignores the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, when importing @asciidoctor/core@3.0.0-alpha.4 with Remix (https://remix.run/) I get the following error:
TypeError: The "path" argument must be of type string or an instance of URL. Received undefinedApplying to this line:
asciidoctor.js/packages/core/src/template-asciidoctor-node.js
Line 12 in aac44ad
This seems to be because
import.meta.urlis not available incjs. Essentially, Remix convertsesmpackages tocjsto run on the server (see here: https://remix.run/docs/en/v1/pages/gotchas#importing-esm-packages).I'm proposing we keep the release as it is, but copy over the
cjsas a fallback so it can be used as a dual CommonJS/ES module package.