Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getSectionNumeral() function #1659

Merged
merged 8 commits into from
Sep 24, 2022
Merged

Add getSectionNumeral() function #1659

merged 8 commits into from
Sep 24, 2022

Conversation

benjaminleonard
Copy link
Contributor

Currently using $sectnum() in a custom asciidoc section converter—figured it might be useful to get the function wrapper included and typed.

First time contributor, hopefully it's all formatted correctly.

@ggrossetie
Copy link
Member

That's look good! Thank you 😄
As mentioned by Dan on Zulip, could you please use getSectionNumeral as the primary name (and getSectionNumber as an alias)?

When you file the issue, I propose the name getSectionNumeral(). The value is not always a number, which is why we use that terminology. However, I'd also support adding getSectionNumber() as an alias.

https://asciidoctor.zulipchat.com/#narrow/stream/279645-users.2Fasciidoctor.2Ejs/topic/Accessing.20sectnum.20with.20asciidoctor.2Ejs/near/298429578

@benjaminleonard
Copy link
Contributor Author

Oh I missed that, done!

I can add the alias too if you would like—and have an example.

@benjaminleonard benjaminleonard changed the title Add getSectionNumber() function Add getSectionNumeral() function Sep 24, 2022
@ggrossetie
Copy link
Member

I can add the alias too if you would like—and have an example.

I think that would be nice since a lot of users might assume that setnum is short for section number (numeral is less common)

@benjaminleonard
Copy link
Contributor Author

Done! (I think)

@ggrossetie
Copy link
Member

It looks good, thanks again, I will merge it once the build is successful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants