Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify table option checks #1656

Merged
merged 1 commit into from
Sep 22, 2022
Merged

simplify table option checks #1656

merged 1 commit into from
Sep 22, 2022

Conversation

mojavelinux
Copy link
Member

  • use isOption instead of retreiving all attributes, looking for the low-level attribute, and comparing its value

@mojavelinux
simplify table option checks
e61d575 
- use isOption instead of retreiving all attributes, looking for the low-level attribute, and comparing its value
@ggrossetie
Copy link
Member

LGTM, thanks 👍🏻

@ggrossetie ggrossetie merged commit a17dd6e into asciidoctor:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mojavelinux @ggrossetie