Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove call to convert() on return value of process method for inline macro extension #1653

Merged
merged 1 commit into from
Sep 16, 2022
Merged

remove call to convert() on return value of process method for inline macro extension #1653

merged 1 commit into from
Sep 16, 2022

Conversation

mojavelinux
Copy link
Member

  • the process method should return an Inline object, not a string

@mojavelinux
remove call to convert() on return value of process method for inline…
f18e6a8 
… macro extension

- the process method should return an Inline object, not a string
@ggrossetie ggrossetie merged commit dc9276a into asciidoctor:main Sep 16, 2022
@ggrossetie
Copy link
Member

👍

@mojavelinux mojavelinux deleted the fix-inline-macro-extension-example branch September 16, 2022 09:06
@mojavelinux
Copy link
Member Author

Thanks for merging! In order to make this live, I think it needs to be backported to the v2.2.x branch too.

ggrossetie pushed a commit that referenced this pull request Sep 19, 2022
@mojavelinux @ggrossetie
remove call to convert() on return value of process method for inline…
8a26db2 
… macro extension (#1653)

- the process method should return an Inline object, not a string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mojavelinux @ggrossetie