resolves #1475 bridge common Ruby object methods (backport v2.2.x) #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also uses the spread assignment, which wouldn't work in IE either. However, a more portable and likely more efficient way of doing it is: var args = Array.prototype.slice.call(arguments, 1) |
Good suggestion, thanks! |
1 task
This was referenced Mar 8, 2022
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/from which is not available in IE.
I think we should mention that in the next release but I don't want to include a polyfill.