@mojavelinux I would be interesting in hearing your thoughts. The main issue is when we call ConverterFactory.register with an instance (created from a plain JavaScript class):

class DummyConverter {
  // ...
}

asciidoctor.ConverterFactory.register(new DummyConverter(), ['dummy'])

In this case, the instance is missing quite a few Ruby methods.
It's possible to use Opal.klass to bridge a native JS class but as far as I know it's not possible to bridge a instance:

https://github.com/opal/opal/blob/a46adeac3cb7b5e13a8ac9e77dd3aa11278ccef8/opal/corelib/runtime.js#L625-L651

Also, we would need to specify the "superclass" in the register function.

It seems reasonable to me. I'll admit, I'm not a big fan of this porcelain APIs because of the bridging that has to happen underneath. (I prefer to work within Opal). But I understand that it's important to a certain group of users...and thus the details should be hidden as much as possible in those cases.

It seems reasonable to me.

👍🏻

I'll admit, I'm not a big fan of this porcelain APIs because of the bridging that has to happen underneath. (I prefer to work within Opal). But I understand that it's important to a certain group of users...and thus the details should be hidden as much as possible in those cases

Yes it's a trade-off, the porcelain API is not perfect and won't give the full power of using Opal directly but it's definitely more pleasant to use when you are not familiar with Opal.

Hi, is there any plan when this fix is integrated ?

Hi all, also interested in hearing the timeline for integration of this fix.

Thank you :D .

@jayczech23 Since it's a low-level bug fix I'm curious to know why you are waiting for this fix? Are you using the AsciiDoc Slides VS code extension?

@Mogztter, I am actually attempting to implement RevealJS into an Electron app, came across this error when using Asciidoctor RevealJS API described in docs