Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rename "JSDoc" to "API Reference" and add link to extension API reference #1447

Merged
merged 3 commits into from
Oct 18, 2021

Conversation

hqurve
Copy link

@hqurve hqurve commented Oct 17, 2021

No description provided.

@@ -1,6 +1,7 @@
= Extensions

Asciidoctor provides an extension API that offers a xref:extensions/register.adoc[list of extension points] that open up the language to new use cases.
https://asciidoctor.github.io/asciidoctor.js/{jsdoc-version}/#extensions[Extension API Reference]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably "introduce" this link, something like:

Suggested change
https://asciidoctor.github.io/asciidoctor.js/{jsdoc-version}/#extensions[Extension API Reference]
Please refer to the https://asciidoctor.github.io/asciidoctor.js/{jsdoc-version}/#extensions[API Reference] to learn more about the Asciidoctor.js API.

What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus since its linking to the extensions section, it would be "...Asciidoctor.js Extension API"

@@ -4,4 +4,4 @@
** xref:extract-api.adoc[Extract information from a document]
** xref:manipulate-api.adoc[Manipulate a document]
** xref:logging-api.adoc[Logging]
* https://asciidoctor.github.io/asciidoctor.js/{jsdoc-version}/[JSDoc]
* https://asciidoctor.github.io/asciidoctor.js/{jsdoc-version}/[API Reference]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, here's how it will look like:

image

I wonder if we should remove the "s" in "CLI References". I actually don't remember why we put an "s" 😅

And maybe we should put the "API Reference" after "Extend & Customize"?

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe we should put the "API Reference" after "Extend & Customize"?

I was thinking this, but I didnt know if there was a specific reason why JSDOC was in the processor nav file

@ggrossetie
Copy link
Member

Thanks @hqurve 👍🏻

@ggrossetie ggrossetie merged commit 5e9cc0a into asciidoctor:v2.2.x Oct 18, 2021
@hqurve
Copy link
Author

hqurve commented Oct 18, 2021

@Mogztter It appears as if I ended up doing more harm than good. Its no longer showing the API reference text. I believe that its because its because I made it as an empty list

Screenshot from 2021-10-18 15-27-03

@ggrossetie
Copy link
Member

Indeed, the list structure was incorrect: 02ba973
Now it's fixed:

docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants