Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Fix Graal url to run JS #1290

Merged
merged 1 commit into from
May 7, 2021
Merged

📝 Fix Graal url to run JS #1290

merged 1 commit into from
May 7, 2021

Conversation

abelsromero
Copy link
Member

Seems the url to the Graal docs has changed.
This PR just updates it to avoid a 404.

@abelsromero
Copy link
Member Author

Also found this other urls: no sure which one you wanted to use:

@ggrossetie
Copy link
Member

Seems the url to the Graal docs has changed.

Sigh 😞

This PR just updates it to avoid a 404.
Also found this other urls: no sure which one you wanted to use...

Thanks!
I think we should use https://www.graalvm.org/reference-manual/embed-languages/ as far as I remember this is the closest to what https://www.graalvm.org/docs/graalvm-as-a-platform/embed/ was about.

@abelsromero
Copy link
Member Author

Sigh 😞

It's more a build issue. I know the site somehow checks links with https://github.com/asciidoctor/docs.asciidoctor.org/blob/main/checklinks.js. At least I've seen the messages when doing PRs on docs.asciidoctor.org, but we don't get any notification when there's a change in the contents repo. I wonder if there's at least a log we can check in netlify....

@ggrossetie
Copy link
Member

It's more a build issue.

I said "sigh" because breaking documentation URL is bad! I'm a bit disappointed by GraalVM, they didn't bother to redirect https://www.graalvm.org/docs/graalvm-as-a-platform/embed/ to https://graalvm.org/reference-manual/embed-languages

I know the site somehow checks links with https://github.com/asciidoctor/docs.asciidoctor.org/blob/main/checklinks.js. At least I've seen the messages when doing PRs on docs.asciidoctor.org, but we don't get any notification when there's a change in the contents repo. I wonder if there's at least a log we can check in netlify....

I don't think we check external links? Do we?
I found the following log on Netlify: https://app.netlify.com/sites/asciidoctor-docs/deploys/6090cc8189d283a0a6aed6dd

6:25:40 AM: ────────────────────────────────────────────────────────────────
6:25:40 AM:   2. onPostBuild command from netlify-plugin-checklinks         
6:25:40 AM: ────────────────────────────────────────────────────────────────
6:25:40 AM: ​
6:27:07 AM: ...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................,..........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................,..................................................................................................................................................................................................................................................................................................................................
6:27:07 AM:   2585 tests
6:27:07 AM:      2 skipped
6:27:07 AM:   2585 passed
6:27:07 AM: ​
6:27:07 AM: (netlify-plugin-checklinks onPostBuild completed in 1m 26.3s)

@ggrossetie ggrossetie changed the title Fix Graal url to run JS 📝 Fix Graal url to run JS May 7, 2021
@ggrossetie ggrossetie merged commit 628cdc5 into asciidoctor:master May 7, 2021
This was referenced Jun 25, 2023
Open
Open
Closed
Closed
Open
Closed
@ScriptedAlchemy ScriptedAlchemy mentioned this pull request Jun 29, 2023
Closed
1 task
@ggrossetie ggrossetie mentioned this pull request Nov 2, 2023
Closed
1 task
@ggrossetie ggrossetie mentioned this pull request Jun 20, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abelsromero @ggrossetie